diff --git a/.github/scripts/run_tests.py b/.github/scripts/run_tests.py index 88e8a006ef105a658dc3c56febe049f89d81ebff..c1c554afce05ec27a66d394f6e202dbfebbcf084 100644 --- a/.github/scripts/run_tests.py +++ b/.github/scripts/run_tests.py @@ -104,10 +104,6 @@ subprocess.check_call( ) print("Created ./reproducible.tar.gz.") -if run_return_code != 0: - print("Run failed") - raise run_exception - difference_reports = glob.glob(os.path.join(results_folder, f"{test_name}*.rpt")) if len(difference_reports): print("Verbose differences within the benchmark:") @@ -125,4 +121,8 @@ if os.path.exists(design_test_report): print("Testing the design has failed.") exit(-1) +if run_return_code != 0: + print("Run failed") + raise run_exception + print("Done.") diff --git a/.github/workflows/openlane_ci.yml b/.github/workflows/openlane_ci.yml index 6e4fb3e4123cbeda52ef89ea332c5fb3463b7b53..6bc1046c56737b48ae7a43a1c29bc5deacfb920f 100644 --- a/.github/workflows/openlane_ci.yml +++ b/.github/workflows/openlane_ci.yml @@ -141,6 +141,8 @@ jobs: matrix: ${{ fromJSON(needs.prepare_test_matrices.outputs.issue_regression_matrix) }} steps: - uses: actions/checkout@v3 + with: + submodules: true - name: Set up environment variables uses: ./.github/actions/set_env_variables @@ -233,6 +235,7 @@ jobs: python3 ${GITHUB_WORKSPACE}/.github/scripts/run_tests.py ${{ matrix.design.name }} - name: Escape Design Name + if: ${{ always() }} run: | design_name=${{ matrix.design.name }} escaped_design_name=${design_name//\//_} diff --git a/dependencies/tool_metadata.yml b/dependencies/tool_metadata.yml index 1f6826732300b4c319679093f2e5683b4ee0354c..525bb41f6cf5ff12f7466fb01655f60aa2320f65 100644 --- a/dependencies/tool_metadata.yml +++ b/dependencies/tool_metadata.yml @@ -56,7 +56,7 @@ in_install: false - name: openroad_app repo: https://github.com/The-OpenROAD-Project/OpenROAD - commit: 6f9b2bb8b808b1bb5831d4525d868212ae50517a + commit: 75f2f325b7a42e56a92404f33af8e96530d9b202 in_install: false - name: git repo: https://github.com/git/git diff --git a/designs/ci b/designs/ci index ec48b853d4958b46f559562a31363e59e89216ef..6676a20db8775e0ca9a6df099e807b4951b8da6f 160000 --- a/designs/ci +++ b/designs/ci @@ -1 +1 @@ -Subproject commit ec48b853d4958b46f559562a31363e59e89216ef +Subproject commit 6676a20db8775e0ca9a6df099e807b4951b8da6f diff --git a/run_designs.py b/run_designs.py index ccb27694b566371b3325a9280ce56e080ed76a84..07f1d0ec7359c0395ed3c1ef59f40a4382f4a3ee 100755 --- a/run_designs.py +++ b/run_designs.py @@ -398,7 +398,7 @@ def cli( design, f"Failed to compare with benchmark: {error_msg}", ) - flow_failure_flag = True + design_failure_flag = True if delete: try: diff --git a/tests/1935-cts-crash/interactive.tcl b/tests/1935-cts-crash/interactive.tcl new file mode 100644 index 0000000000000000000000000000000000000000..cab7b4f2cdae9632a22abb41b288bef7c2918f35 --- /dev/null +++ b/tests/1935-cts-crash/interactive.tcl @@ -0,0 +1,3 @@ +exec bash -c "set -e && \ + cd [file dirname [file normalize [info script]]]/reproducible && \ + tar xvf issue.tar.gz && cd issue_reproducible && bash run.sh" diff --git a/tests/1935-cts-crash/reproducible b/tests/1935-cts-crash/reproducible new file mode 120000 index 0000000000000000000000000000000000000000..d48c957376e872d0124b5bc3a37e28d9f0b2d63e --- /dev/null +++ b/tests/1935-cts-crash/reproducible @@ -0,0 +1 @@ +../../designs/ci/reproducibles/1935/ \ No newline at end of file diff --git a/tests/2060-resizer-crash/interactive.tcl b/tests/2060-resizer-crash/interactive.tcl new file mode 100644 index 0000000000000000000000000000000000000000..9a4d4977ad633cea83dca31d33038d38d198a9a7 --- /dev/null +++ b/tests/2060-resizer-crash/interactive.tcl @@ -0,0 +1,2 @@ +exec bash -c "set -e && \ + cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh" diff --git a/tests/2060-resizer-crash/reproducible b/tests/2060-resizer-crash/reproducible new file mode 120000 index 0000000000000000000000000000000000000000..c7851cba6f1f5deacee0f0dae49ddb18e072da9c --- /dev/null +++ b/tests/2060-resizer-crash/reproducible @@ -0,0 +1 @@ +../../designs/ci/reproducibles/2060/issue_reproducible \ No newline at end of file diff --git a/tests/2065-resizer-crash/interactive.tcl b/tests/2065-resizer-crash/interactive.tcl new file mode 100644 index 0000000000000000000000000000000000000000..9a4d4977ad633cea83dca31d33038d38d198a9a7 --- /dev/null +++ b/tests/2065-resizer-crash/interactive.tcl @@ -0,0 +1,2 @@ +exec bash -c "set -e && \ + cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh" diff --git a/tests/2065-resizer-crash/reproducible b/tests/2065-resizer-crash/reproducible new file mode 120000 index 0000000000000000000000000000000000000000..8ff8a7825078e7b3813b5ccfbb21f1f587e43669 --- /dev/null +++ b/tests/2065-resizer-crash/reproducible @@ -0,0 +1 @@ +../../designs/ci/reproducibles/2065/issue_reproducible \ No newline at end of file