Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Iris Iris
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • IrisIris
  • Merge requests
  • !413

Kill `{o,r,ur}Functor_diag` coercions, and rename into `{o,r,ur}Functor_apply`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robbert Krebbers requested to merge robbert/functor_diag into master Apr 01, 2020
  • Overview 23
  • Commits 5
  • Pipelines 0
  • Changes 8

Various reasons for doing this:

  • Most of the time we are interested in oFunctor_car, so it's really confusing that oFunctor_diag is a coercion
  • The coercion doesn't work well with the Cofe type class argument (see !257 (merged))---an underscore _ is needed when applying the coercion.
  • The coercion is very little used, so better to be explicit, especially in light of #240 (closed).

/cc @iris-users This is a breaking change.

This MR closes issue #240 (closed).

Edited Apr 01, 2020 by Robbert Krebbers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: robbert/functor_diag