Fix most of clippy::style

Part of #7.

This MR has fixed many of the clippy::style lints, in alphabetical order.

Since the beginning of this refactoring, Rust warnings about dead code have been elided, only focusing on syntactic changes. However, some clippy lints require manual and human checking for functions that are, at the end, unused.

Therefore, this MR has temporary stopped fixing lints from clippy::style and fixed rust lints (except deprecated: will be fixed in another MR).

---

The most important commit are 9dd74a86 and 730b2ec9.

Feel free to leave a comment on any function or structure field that you would like to keep. However, since you're modifying traits in a different branch, do not flag the suppressed functions you'll be using: We'll reintroduce them properly later.

Also, let me know if the functions from the dump_borrowck_info.rs file are used for debugging purposes: It might be interesting to move these functions into a specific development mode.

requested review from @lgaeher

changed the description

Thanks a lot! After looking over the diff a bit, I feel like it would be good to split this into multiple MRs. The diffs for match_like_matches and len_zero contain some changes that don't seem directly related to me, and since these are logical changes need a bit closer review, I think. dead_code removes some things I'd like to keep (for debugging purposes and future use), so that also needs closer examination.

If you can create an MR with all but the three commits mentioned above, that seems pretty uncontroversial, and then it's easier to focus on the relevant changes when reviewing the other three commits

added 6 commits

• d0619f51 - clippy: Fix len_zero
• e8291cac - clippy: Fix let_and_return
• c45e0c6a - clippy: Fix manual_map
• d36b96e6 - clippy: Fix manual_while_let_some
• db44bb38 - clippy: Fix map_clone
• a2a298e2 - clippy: Fix match_like_matches_macro

Compare with previous version

changed title from Fix most of clippy::style and rust lints to Fix most of clippy::style

changed the description

resolved all threads

approved this merge request

I think this looks good. Can you create a separate MR when it's convenient with the other three commits (maybe without the dead_code lint)?

merged

changed the description

mentioned in merge request !43 (merged)