Skip to content
Snippets Groups Projects

coding style adjustments in prosa.util.exists_extensionality

Closed Björn Brandenburg requested to merge feedback into wip-edf-wc

I've edited your addition in prosa.util to highlight some ways in which I'd like you to adhere more to the Prosa coding style:

  1. Use coqdoc comments before any top-level item.

  2. Introduce context (types, hypothesis, variables) with comments as section variables.

  3. Either use structured sub-proofs (bullet points or curly braces) or dispatch in one go with chained ;.

  4. Use P and Q as "standard" names for predicates. (This one isn't so important. Just cosmetics.)

Let me know if you have any questions.

Merge request reports

Pipeline #30782 failed

Pipeline failed for 79cac060 on feedback

Approval is optional

Closed by Björn BrandenburgBjörn Brandenburg 4 years ago (Aug 4, 2020 1:31pm UTC)

Merge details

  • The changes were not merged into wip-edf-wc.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading