Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Iris Iris
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • IrisIris
  • Merge requests
  • !294

Try getting rid of total Core typeclass

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ralf Jung requested to merge ralf/total-core into master Jul 14, 2019
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 5

The only instance of Core (other than the default one) is for the STS. That does not seem worth it. But trying to get rid of Core leads to all sorts of annoyances in particular around the constructors for (CM)RAs with a unit: I thought we should also change the (cm)ra_total constructors to ask for showing pcore non-expansive instead of core as it seemed more reasonable to ask for a proof of what the user actually wanted. However, that fails miserably; now "by eauto" does not solve these goals any more. Debugging showed that different instances get used for the metric/equiv of option, and that's about as far as I got.

@robbertkrebbers I'd appreciate if you can take a look (but this is very non-urgent).

Edited Dec 02, 2019 by Robbert Krebbers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ralf/total-core