Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Iris Iris
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • IrisIris
  • Merge requests
  • !521

Make `iFrame` "less" smart w.r.t. clean up of modalities.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robbert Krebbers requested to merge robbert/more_dumb_iFrame into master Sep 29, 2020
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 2

Previously, iFrame would "cleanup" <affine> and □ if the result after framing is affine and intuitionistic, respectively. This behavior was inconsistent, since similar "cleanup" was not performed for <absorbing> and <persistent>. This MR thus removes this "cleanup" of modalities. It now consistently removes the modalities <affine>, <absorbing>, <persistent> and □ only if the result after framing is True or emp.

Since iFrame is already very complicated, and since its performance is sometimes suboptimal in bigger developments, @jung and I believed doing fewer "smart" things is better than the alternative, namely performing doing sophisticated "cleanup" for all modalities, which is presented in !450 (closed)

Edited Jul 13, 2022 by Robbert Krebbers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: robbert/more_dumb_iFrame