Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Iris Iris
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • IrisIris
  • Merge requests
  • !788

Fix bug in `iApply` prettification.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robbert Krebbers requested to merge robbert/iApply_pretty into master Apr 20, 2022
  • Overview 2
  • Commits 2
  • Pipelines 3
  • Changes 3

Situation before this MR:

From iris.proofmode Require Import tactics.

Lemma test_iApply_reduce {PROP : bi} (Ψ Φ : nat → PROP) :
  (∀ f y, TCEq f (λ x, x + 10) → Ψ (f 1) -∗ Φ y) →
  Ψ 11 -∗ Φ 10.
Proof.
  iIntros (HP) "H".
  iApply HP. (* [Ψ ((λ x : nat, x + 10) 1)] does not reduce *)
  reduction.pm_reduce. (* [Ψ (1 + 10)] does reduce *)
Restart.
  iIntros (HP) "H".
  iApply (HP _ _ _). (* [Ψ (1 + 10)] does reduce *) 
  iApply "H".
Qed.

This MR fixes this problem by moving the pm_prettify to the outside. This is needed because only at that moment all TCs have been solved.

Edited Apr 20, 2022 by Robbert Krebbers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: robbert/iApply_pretty