Skip to content
Snippets Groups Projects

Renamed `app_cons_eq_inv_{l,r}`, and added derived versions for `prefix/suffix`

Merged Jonas Kastberg requested to merge jihgfee/stdpp:prefix_lemmas into master
All threads resolved!

Renamed the lemmas app_cons_eq_inv_{l,r}, to elem_of_app_cons_inv_{l,r}, to be more descriptive and consistent with existing lemmas.

Additionally, derived versions for prefix/suffix, as they recall some non-immediate properties of the relations on similar list structures.

Edited by Jonas Kastberg

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robbert Krebbers mentioned in merge request !363 (merged)

    mentioned in merge request !363 (merged)

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 2a3b29da - Made proof of [prefix_app_inv] in line with that of [suffix_app_inv]

    Compare with previous version

  • Can you rebase, add the lemma for postfix, and put them in the same style as the ones in !363 (merged).

  • Jonas Kastberg added 28 commits

    added 28 commits

    • 2a3b29da...f71300ea - 26 commits from branch iris:master
    • fb27a857 - Added useful lemmas for [prefix]
    • 22e7199d - Made proof of [prefix_app_inv] in line with that of [suffix_app_inv]

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 844a0f13 - Added suffix variant, renamed lemmas, proved in terms of existing

    Compare with previous version

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Robbert Krebbers
  • Robbert Krebbers
  • Can you also update the title + description of this MR?

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 8d2492d9 - Improved proofs and changed names of lemmas

    Compare with previous version

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Jonas Kastberg changed title from Added useful lemmas for [prefix] to Added {+derived versions of app_cons_eq_inv_{l,r}+} for {++}prefix{+/suffix+}

    changed title from Added useful lemmas for [prefix] to Added {+derived versions of app_cons_eq_inv_{l,r}+} for {++}prefix{+/suffix+}

  • Jonas Kastberg changed the description

    changed the description

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Jonas Kastberg added 1 commit

    added 1 commit

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 2b4f0c78 - Changed names of lemmas again

    Compare with previous version

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Jonas Kastberg added 1 commit

    added 1 commit

    Compare with previous version

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 346342ba - Another name change - Also for dependent lemmas

    Compare with previous version

  • LGTM. Can you update the MR title and add a proper description in the text (including documenting the recent renames)?

  • Jonas Kastberg changed title from {-Added derived versions of app_cons_eq_inv_{l,r}-} for prefix/suffix to {+Renamed app_cons_eq_inv_{l,r}, and added derived versions+} for prefix/suffix

    changed title from {-Added derived versions of app_cons_eq_inv_{l,r}-} for prefix/suffix to {+Renamed app_cons_eq_inv_{l,r}, and added derived versions+} for prefix/suffix

  • Jonas Kastberg changed the description

    changed the description

  • @iris-users This MR is a breaking change if you already rely on the lemmas from !363 (merged) (merged 5 days ago).

  • mentioned in commit 907a40ef

  • Thanks @jihgfee for the fixes! Merged.

  • Please register or sign in to reply
    Loading