Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S stdpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 81
    • Issues 81
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • stdpp
  • Merge requests
  • !411

Fix unfolding logic of bv_simplify

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Sammler requested to merge msammler/bv_simplify_fix into master Aug 25, 2022
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 3

bv_simplify should always produce equalities on Z, but due to a bug it turned bv_wrap n (bv_unsigned b) = bv_wrap n (bv_unsigned b) into b = b, which means that bv_solve fails on bv_wrap n (bv_unsigned b) = bv_wrap n (bv_unsigned b). This MR fixes this bug which is caused by apply applying an ↔ lemma in the wrong direction.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: msammler/bv_simplify_fix