Skip to content
Snippets Groups Projects

Fix slowdown in bv_saturate from https://github.com/coq/coq/pull/17984

Merged Michael Sammler requested to merge msammler/euclidean_division_cleanup_slowdown into master
1 unresolved thread

https://github.com/coq/coq/pull/17984 causes a significant slowdown in Islaris since the changed Z.euclidean_division_equations_cleanup function can be become very slow if there are many hypothesis of the form 0 <= ... < ... in the context. This MR works around this by changing bv_saturate to generate hypothesis of the form -1 < ... < ... instead of 0 <= ... < .... This change speeds up some case studies in Islaris by up to 30%, see here.

Merge request reports

Merge request pipeline #98287 passed

Merge request pipeline passed for 1af7cb9d

Approval is optional

Merged by Ralf JungRalf Jung 1 year ago (Mar 11, 2024 5:17pm UTC)

Merge details

  • Changes merged into master with a8c0c0f8.
  • Deleted the source branch.

Pipeline #98304 passed

Pipeline passed for a8c0c0f8 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading