create new package for stdpp-bitvector library
This is a step towards #204 (closed).
I was not quite sure which Coq logical path to use for this. For now I used stdpp.bv
since always typing stdpp.bitvector
seems a bit annoying, but the inconsistency may also be confusing. Opinions?
Merge request reports
Activity
- Resolved by Ralf Jung
- Resolved by Michael Sammler
- Resolved by Ralf Jung
Thanks @jung for creating this MR! I added my thoughts above.
- Resolved by Ralf Jung
- Resolved by Robbert Krebbers
I am not the biggest fan of
bitvector.bitvector_tactics
. I am not sure if we have prior examples from which we can take inspiration for better naming.We do have
proofmode.proofmode
, but that will give the whole of the proofmode, so it's different than what we have here.
added 1 commit
- b60d511f - bitvector.bitvector_tactics -> bitvector.tactics
- Resolved by Robbert Krebbers
LGTM -- @robbertkrebbers any final remarks?
@msammler can you add a changelog entry?
If this is supposed to be included in the upcoming release, it should land today. I hope to tag the release tomorrow.
Edited by Ralf Jungadded 1 commit
- 6a27d1a2 - add change log entry for bitvector package and remove stdpp_unstable/.keep
- Resolved by Michael Sammler
- Resolved by Robbert Krebbers
This needs a rebase to resolve the conflicts.
added 8 commits
-
6a27d1a2...a91260bd - 6 commits from branch
master
- 1138384a - update file structure
- 258bb528 - Merge remote-tracking branch 'origin/master' into ralf/bitvector
-
6a27d1a2...a91260bd - 6 commits from branch
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
- Resolved by Michael Sammler
added 5 commits
Toggle commit listI am happy. Any last remarks @jung ?
mentioned in commit 614f8ccc
mentioned in issue #204 (closed)