Skip to content
Snippets Groups Projects

create new package for stdpp-bitvector library

Merged Ralf Jung requested to merge ralf/bitvector into master
All threads resolved!

This is a step towards #204 (closed).

I was not quite sure which Coq logical path to use for this. For now I used stdpp.bv since always typing stdpp.bitvector seems a bit annoying, but the inconsistency may also be confusing. Opinions?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Sammler
  • Thanks @jung for creating this MR! I added my thoughts above.

  • Michael Sammler added 1 commit

    added 1 commit

    • e629b174 - pass over new stdpp-bitvector package

    Compare with previous version

  • I made a pass over this MR and pushed the changes directly to this MR. All comments from my side should be resolved now.

  • Ralf Jung
  • Ralf Jung resolved all threads

    resolved all threads

  • Author Owner

    That all looks good to me. :)

    • Resolved by Robbert Krebbers

      I am not the biggest fan of bitvector.bitvector_tactics. I am not sure if we have prior examples from which we can take inspiration for better naming.

      We do have proofmode.proofmode, but that will give the whole of the proofmode, so it's different than what we have here.

  • Michael Sammler added 1 commit

    added 1 commit

    • b60d511f - bitvector.bitvector_tactics -> bitvector.tactics

    Compare with previous version

  • Ralf Jung resolved all threads

    resolved all threads

  • Author Owner

    If this is supposed to be included in the upcoming release, it should land today. I hope to tag the release tomorrow.

    Edited by Ralf Jung
  • added 1 commit

    • 6a27d1a2 - add change log entry for bitvector package and remove stdpp_unstable/.keep

    Compare with previous version

  • Ralf Jung
  • added 8 commits

    Compare with previous version

  • Robbert Krebbers
  • Robbert Krebbers
  • Robbert Krebbers
  • Robbert Krebbers
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 5 commits

    • f200f93d - create new package for stdpp-bitvector library
    • b815c10b - pass over new stdpp-bitvector package
    • 6c1e9be8 - bitvector.bitvector_tactics -> bitvector.tactics
    • 6da05b7a - add change log entry for bitvector package and remove stdpp_unstable/.keep
    • ab90b0bc - update file structure

    Compare with previous version

  • Michael Sammler resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • I am happy. Any last remarks @jung ?

  • Author Owner

    LGTM. Thanks for finishing is before the release :)

  • Ralf Jung mentioned in commit 614f8ccc

    mentioned in commit 614f8ccc

  • merged

  • mentioned in issue #204 (closed)

  • Please register or sign in to reply
    Loading