Skip to content
Snippets Groups Projects

only locally make uPred_holds a coercion

Merged Ralf Jung requested to merge ralf/less-coerce into master
All threads resolved!

uPred_holds being a coercion globally breaks the uPred abstraction. So only make it a coercion in modules that go into the model anyway.

While at it, I did the same for siProp.

Edited by Ralf Jung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM, modulo nit about comment.

  • Ralf Jung added 2 commits

    added 2 commits

    • 48068213 - only locally make uPred_holds a coercion
    • 2c1dd026 - only locally make siProp_holds a coercion

    Compare with previous version

  • Looks good to me.

  • Robbert Krebbers resolved all threads

    resolved all threads

  • merged

  • Ralf Jung mentioned in commit c4ea27fb

    mentioned in commit c4ea27fb

  • Author Owner

    @iris-users this is a breaking change if you were relying on the uPred_holds coercion (which should be rare, it only happens when you go down into the model of Iris).

  • Please register or sign in to reply
    Loading