Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Iris Iris
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • IrisIris
  • Merge requests
  • !739

don't make frame_fractional an instance

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ralf Jung requested to merge ci/ralf/frame-frac into master Oct 01, 2021
  • Overview 20
  • Commits 3
  • Pipelines 8
  • Changes 4

Instead, just add a concrete instance for ↦. This prevents TC search from trying AsFractional framing everywhere.

Let us see how much performance removing that instance brings, and how much convenience it costs. On Iris itself, this speeds up heap_lang.lib by 0.8%. iris/examples results can be found here.

Fixes #351 (closed)

Edited Nov 29, 2021 by Ralf Jung
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ci/ralf/frame-frac