Skip to content
Snippets Groups Projects

Updated suggested emacs indendation configuration

Merged Jonas Kastberg requested to merge jihgfee/iris-coq:indentations into master
All threads resolved!

The currently suggested indentation configuration for does not give the wanted indentations for newer version of proof-general.

For instance is no longer used, as it would indent statements as follows in newer versions of proof-general:

  P *
    Q

We now rather use ->, which indents them in the same way across versions:

  P *
  Q

EDIT: Typo

Edited by Ralf Jung

Merge request reports

Merge request pipeline #65795 passed

Merge request pipeline passed for f486ef4e

Approval is optional

Merged by Ralf JungRalf Jung 2 years ago (May 11, 2022 2:33pm UTC)

Merge details

  • Changes merged into master with dacf718e (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #65796 passed

Pipeline passed for dacf718e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I am not a proof general user, so I don't have an opinion about this. Waiting for a review from someone who knows proof general.

  • I am using PG but don't know this indentation configuration magic. :D

    But I agree with the example in the PR, we want

    P ∗
    Q

    That is also what we ask Coq to use for formatting. So as long as you agree with this, @robbertkrebbers, I am fine with landing the MR.

  • Yes, we want

    P ∗
    Q

    instead of

    P ∗
      Q

    So, @jihgfee can you maybe try to improve the sentence in the docs a bit, then we can merge?

  • Jonas Kastberg added 63 commits

    added 63 commits

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 1bb9d3f6 - Improved indentation configuration documentation

    Compare with previous version

  • Ralf Jung
  • Ralf Jung
  • Jonas Kastberg added 1 commit

    added 1 commit

    • f19892d9 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 7962ba3d - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 98e2ee31 - Removed overly-specific indentation rules

    Compare with previous version

  • Ralf Jung resolved all threads

    resolved all threads

  • Ralf Jung added 1 commit

    added 1 commit

    Compare with previous version

  • Ralf Jung
  • Ralf Jung resolved all threads

    resolved all threads

  • Ralf Jung added 1 commit

    added 1 commit

    Compare with previous version

  • Ralf Jung
  • Ralf Jung
  • Ralf Jung added 1 commit

    added 1 commit

    Compare with previous version

  • All right, LGTM modulo squashing the commits together and resolving the last open thread.

  • Jonas Kastberg added 1 commit

    added 1 commit

    • 7d544510 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jonas Kastberg added 1 commit

    added 1 commit

    • f486ef4e - Added one more missing parenthesis

    Compare with previous version

  • Jonas Kastberg resolved all threads

    resolved all threads

  • Ralf Jung changed title from Updated suggested indendation configurations to Updated suggested emacs indendation configuration

    changed title from Updated suggested indendation configurations to Updated suggested emacs indendation configuration

  • Ralf Jung enabled an automatic merge when the pipeline for f486ef4e succeeds

    enabled an automatic merge when the pipeline for f486ef4e succeeds

  • merged

  • Ralf Jung mentioned in commit dacf718e

    mentioned in commit dacf718e

  • Please register or sign in to reply
    Loading