Skip to content
Snippets Groups Projects
Unverified Commit 8bea8c51 authored by Kareem Farid's avatar Kareem Farid Committed by GitHub
Browse files

Update `OpenROAD` (#2062)

~ openroad_app -> `75f2f32`

## CI
~ Always compare regression and create reproducibles
~ Always escape design name
+ Add tests for attached crashes by adding issues reproducibles in designs submodules and symlink them to interactive scripts under ./tests
+ Fix failing designs in extended test:
  * salsa20: setup violations
  * y_huff: routing congestion
  * aes_core: pin antenna violations benchmark mismatch
parent 892d791f
No related branches found
No related tags found
No related merge requests found
......@@ -104,10 +104,6 @@ subprocess.check_call(
)
print("Created ./reproducible.tar.gz.")
if run_return_code != 0:
print("Run failed")
raise run_exception
difference_reports = glob.glob(os.path.join(results_folder, f"{test_name}*.rpt"))
if len(difference_reports):
print("Verbose differences within the benchmark:")
......@@ -125,4 +121,8 @@ if os.path.exists(design_test_report):
print("Testing the design has failed.")
exit(-1)
if run_return_code != 0:
print("Run failed")
raise run_exception
print("Done.")
......@@ -141,6 +141,8 @@ jobs:
matrix: ${{ fromJSON(needs.prepare_test_matrices.outputs.issue_regression_matrix) }}
steps:
- uses: actions/checkout@v3
with:
submodules: true
- name: Set up environment variables
uses: ./.github/actions/set_env_variables
......@@ -233,6 +235,7 @@ jobs:
python3 ${GITHUB_WORKSPACE}/.github/scripts/run_tests.py ${{ matrix.design.name }}
- name: Escape Design Name
if: ${{ always() }}
run: |
design_name=${{ matrix.design.name }}
escaped_design_name=${design_name//\//_}
......
......@@ -56,7 +56,7 @@
in_install: false
- name: openroad_app
repo: https://github.com/The-OpenROAD-Project/OpenROAD
commit: 6f9b2bb8b808b1bb5831d4525d868212ae50517a
commit: 75f2f325b7a42e56a92404f33af8e96530d9b202
in_install: false
- name: git
repo: https://github.com/git/git
......
Subproject commit ec48b853d4958b46f559562a31363e59e89216ef
Subproject commit 6676a20db8775e0ca9a6df099e807b4951b8da6f
......@@ -398,7 +398,7 @@ def cli(
design,
f"Failed to compare with benchmark: {error_msg}",
)
flow_failure_flag = True
design_failure_flag = True
if delete:
try:
......
exec bash -c "set -e && \
cd [file dirname [file normalize [info script]]]/reproducible && \
tar xvf issue.tar.gz && cd issue_reproducible && bash run.sh"
../../designs/ci/reproducibles/1935/
\ No newline at end of file
exec bash -c "set -e && \
cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh"
../../designs/ci/reproducibles/2060/issue_reproducible
\ No newline at end of file
exec bash -c "set -e && \
cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh"
../../designs/ci/reproducibles/2065/issue_reproducible
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment